496449 - Able to add incomplete add-on to a collection

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.try to add "Thunderbird Tangerine" to a collection

expected result:
User is unable to add "Thunderbird Tangerine" to a collection as its incomplete

actual result:
-Able to add incomplete add-on to a collection
-However the add-on is not listed in the View collection page

screencast:
http://screencast.com/t/zEcvsWRQmTW

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This patch disallows *adding* invalid add-ons to the list. I don't think they were shown in the suggestion dropdown before, so this one must have been added by entering the add-on ID manually?

Note that the existing test case won't magically go away: Only adding such add-ons is refused now.

Also note that if this add-on was added with the extension, it's a bug over there and is unaffected by this patch.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 381736 [details] [diff] [review]
Patch, rev. 1

This doesn't seem to have any effect.

Additionally, the dropdown box does suggest invalid add-ons.  Try typing "Thunderbird tan" in it to see the invalid theme.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 381736 [details] [diff] [review]
Patch, rev. 1

Alright, after discussion on IRC this patch is valid, and thunderbird tangerine is broken.

Comment 4

[Fred Wenzel [:wenzel]]

Comment on attachment 381736 [details] [diff] [review]
Patch, rev. 1

Actually, the code does what it says it does, but we noticed that coincidentally, this specific add-on is broken. Its status is PENDING which is valid, in spite of it actually being incomplete.

If fixed the add-on's status both in production and on preview.

We still need my code though to keep *actual* invalid add-ons from being added to a collection.

Comment 5

[Fred Wenzel [:wenzel]]

r27217, thanks.

Comment 6

[krupa raj[:krupa]]

Trying to add an incomplete add-on(testfreak[9617]) gave an error message-"Add-on not found".

Marking this verified.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"