496724 - Remove from list removes externally downloaded file

Status: RESOLVED DUPLICATE of bug 334835

(Firefox :: File Handling, defect)

Description

[Hari Krishna Dara]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 GTB5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10 GTB5 (.NET CLR 3.5.30729)

I started downloading a file in firefox, but for some reason it didn't start for a few minutes, so I decided to use wget instead. I canceled the download (that hasn't yet begun downloading) in firefox then used wget to finish the download. Right after the download finished, I noticed the unwanted the entry in firefox and removed that entry (right click->Remove from list). This ended up removing the fully downloaded file by an external program. I ended up having to download the file again.

Reproducible: Always

Steps to Reproduce:
1. Start to download a file.
2. Cancel the download, preferably before it starts to download (server busy etc.)
3. Download the file using a different program to the same location with the same name.
4. Let the download be complete.
5. Remove the canceled item from firefox.
6. Notice that the completed file is removed.
Actual Results:  
The file is removed.

Expected Results:  
The download entry cleared WITHOUT deleting the file.

Comment 1

[Gauthier Van Vreckem]

It's in fact worse than that:
You can trigger this within Firefox.

1 Start a download from a bad server (it fail for some reason and cannot resume).
2 Download again from the same server or a mirror and use the same file name to save (overwriting the partially failed file).
3 Let the second download complete.
4 Remove the failed/canceled download from the download list.
5 Notice that the completed file is removed.

Expected result:
The correctly downloaded file still present in the downloads history not being deleted.
I've been bitten by this bug more than once.

It shouldn't be difficult to see that the file has been touched outside of the failed download history (test that moz_downloads.currBytes match file size before deleting it) and thus not to delete it.

Comment 2

[Gauthier Van Vreckem]

this is a duplicate of  Bug 334835, I do not know how to mark it so.