496769 - Show publisher comments in Collection View

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Justin Scott [:fligtar]]

This is something important that was left out of the Clearleft mocks and I didn't notice until now. It will have to wait until 5.0.7 though. :(

In the collection view, if an add-on has publisher comments associated with it, they should be displayed there.

Assigning to myself to attach a mockup.

Comment 1

[Justin Scott [:fligtar]]

Attachment: screenshot

Comment 2

[Justin Scott [:fligtar]]

Attachment: patch, v1

After thinking about it more, I think this blocks 5.0.6. I should have caught this earlier when it wasn't in Clearleft's mocks. It was in the wireframe we gave them (attachment 367634 [details]).

Since it's my fault, I made a patch. It re-uses the review string so doesn't require l10n changes.

Comment 3

[Justin Scott [:fligtar]]

Thanks! r27310

Comment 4

[Jeff Balogh (:jbalogh)]

A query that won't get cached (if I understand our caching correctly) in a loop?

Comment 5

[Justin Scott [:fligtar]]

Stephen, for an example of a collection using these comments, see https://preview.addons.mozilla.org/en-US/firefox/collection/twittertracker

(please don't make any changes to that one - I'm using it in my screencasts :) )

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collection/twittertracker; thanks, Fligtar (no worries, won't touch it).

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> A query that won't get cached (if I understand our caching correctly) in a
> loop?

Why won't it?