496802 - Reskin source-code license page using AMO2009/ClearLeft styles

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/firefox/versions/license/57263 needs a reskinning

Comment 1

[Fred Wenzel [:wenzel]]

I'll pick this up.

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 382103 [details] [diff] [review]
Patch, rev. 1

This works for me, but I don't think it blocks release.  Let's get stephend's input before we land.

Comment 4

[Fred Wenzel [:wenzel]]

r27352. Stephend: Let me know if that looks like you were expecting it to.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; looks fine to me, thanks!

Comment 6

[(no longer active)]

Is there any reason why the h2 (and not the pre element) under the version-license div has lang=en-US and dir=ltr?

Comment 7

[(no longer active)]

(In reply to comment #6)
> Is there any reason why the h2 (and not the pre element) under the
> version-license div has lang=en-US and dir=ltr?

I think this is a mistake in the respective view.  Filed bug 497069.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"