Closed Bug 496980 Opened 15 years ago Closed 15 years ago

Affiliates button HTML is broken

Categories

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Product:
Infrastructure & Operations Graveyard
Component:
WebOps: Other
Type:
task
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: abuchanan, Assigned: oremj)

References

(
URL
)

Details

(Whiteboard: regression) 

The affiliate button HTML is broken.  Per a "Contact Us" email...

I would like to point out that there is a HTML nesting error in the code generated for affiliate links.

Example: <a href='http://www.mozilla.com/?from=sfx&uid=263197&t=329'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/120x240.png' alt='Spread Firefox Affiliate Button' border=0 /></img>

Should read: <a href='http://www.mozilla.com/?from=sfx&uid=263197&t=329'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/120x240.png' alt='Spread Firefox Affiliate Button' border="0" /></a>

The closing tag is for the <a> tag and not the <img> tag as that's already closed using  />. The border=0 should have the 0 enclosed in either single or double quotation marks, ie. border="0"
r27379 checks in a fix to trunk
r27382 checks in a better fix
Whiteboard: regression
this looks fixed on stage

https://spreadfirefox.authstage.mozilla.com/?q=affiliates/get_button&button=3

donner, could you verify?  I'd like to get this fix pushed asap. Thanks.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
(In reply to comment #3)
> this looks fixed on stage
> 
> https://spreadfirefox.authstage.mozilla.com/?q=affiliates/get_button&button=3
> 
> donner, could you verify?  I'd like to get this fix pushed asap. Thanks.

Looks good to me!
r27391 tags this fix for production.

Over to IT to svn up production for Spreadfirefox.com please.

This is a regression and a 1 line fix, so making it a blocker so it gets done tonight.

Thanks guys!
Assignee: buchanae → server-ops
Severity: critical → blocker
Component: spreadfirefox.com → Server Operations: Web Content Push
Product: Websites → mozilla.org
QA Contact: spreadfirefox-com → mrz
Version: unspecified → other
U    sites/all/modules/sfx_affiliates/sfx_affiliates.module
 U   sites/all/modules/sfx_affiliates
Updated to revision 27394.
Assignee: server-ops → oremj
Verified FIXED on prod:

<a href='http://www.mozilla.com/?from=sfx&amp;uid=0&amp;t=305'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/110x32_best-yet.png' alt='Spread Firefox Affiliate Button' border='0' /></a>
Status: RESOLVED → VERIFIED
Component: Server Operations: Web Operations → WebOps: Other
Product: mozilla.org → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.