Closed Bug 497122 Opened 15 years ago Closed 15 years ago

Firefox preferences dialog doesn't display on Linux

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Version:
3.5 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: conraidblank, Unassigned)

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10

Like in https://bugzilla.mozilla.org/show_bug.cgi?id=473991

To display preferences dialog in FF3.5beta4 i have apply this patch that remove brandind dtd


--- preferences.xul.orig        2009-04-23 20:06:20.000000000 +0200
+++ preferences.xul     2009-06-09 17:34:26.000000000 +0200
@@ -14,9 +14,7 @@
 <?xml-stylesheet href="chrome://browser/skin/preferences/applications.css"?>

 <!DOCTYPE prefwindow [
-<!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd">
 <!ENTITY % preferencesDTD SYSTEM
"chrome://browser/locale/preferences/preferences.dtd">
-%brandDTD;
 %preferencesDTD;


Reproducible: Always

Steps to Reproduce:
1.open preferences dialog. It doesn't display content preferences dialog
2.
3.
Actual Results:  
With patch it's ok
Are you running prism in your profile?
No, I don't use prism
however, the error there is also in a new profile or empty profile
I cannot reproduce it with a recent build on Ubuntu 8.10. Which Linux version are you using?

Dao, have you already seen this issue?
Version: unspecified → 3.5 Branch
I using Slackware -current, with kde4.2.4
It works if you *remove* brand.dtd from preferences.xul?

What output do you get when loading <view-source:chrome://branding/locale/brand.dtd>?
mmm...
yesterday works without brand.dtd, today 

XML Parsing Error: undefined entity
Location: chrome://browser/content/preferences/preferences.xul
Line Number 23, Column 1:<prefwindow type="prefwindow"
^

I don't remember all changes

Output is
<!ENTITY  brandShortName        "Firefox">
<!ENTITY  brandFullName         "Mozilla Firefox">
<!ENTITY  vendorShortName       "Mozilla">
<!ENTITY  logoCopyright         "Firefox and the Firefox logos are trademarks of the Mozilla Foundation. All rights reserved.">
with or without brand.dtd

With original preferences.xul screenshot is this
http://img81.imageshack.us/img81/6533/schermata4.png

:-(
The problem is the gtk theme qtcurve
i'm sorry
Huh, how can themes interact so bad with us?
In this theme there are 3 files for mozilla.


$ ls /usr/share/themes/QtCurve/mozilla/
QtCurve-KDEButtonOrder.css  QtCurve.css  preferences-rev.xml

$ cat /usr/share/themes/QtCurve/mozilla/QtCurve-KDEButtonOrder.css 
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"); 

/* Swap Cancel/OK -> OK/Cancel */
.dialog-button-box { -moz-box-direction: reverse; -moz-box-pack: right; }
.dialog-button-box spacer { display: none !important; }                  
prefwindow { -moz-binding: url("file:///usr/share/themes/QtCurve/mozilla/preferences-rev.xml#prefwindow") !important; }

$ cat /usr/share/themes/QtCurve/mozilla/QtCurve.css 
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

/* Dont embolden the text on the selected tab */
tab[selected="true"] { font-weight: normal !important; }

/* Shrink toolbars -> by about 2 pixels :-( ... */
/* Setting explicit heights, messes things up when text+icons is shown :-( */
#nav-bar                                                                     
{                                                                            
  margin:0px !important;                                                     
  padding:1px !important;                                                    
  border:0px !important;                                                     
}                                                                            

.textbox-input-box,#identity-box,#urlbar-icons,.autocomplete-history-dropmarker,.searchbar-engine-button,.search-go-container,.box-inherit.button-box                                                                                                       
{                                                                                                                             
  margin:0px !important;                                                                                                      
  padding:0px !important;                                                                                                     
}                                                                                                                             

.searchbar-engine-button
{                       
  margin:0px !important;
  padding:2px !important;
}                        
conraid@mobile:/usr/share/themes/QtCurve/mozilla$ cat 
QtCurve-KDEButtonOrder.css  QtCurve.css                 preferences-rev.xml         


$ cat /usr/share/themes/QtCurve/mozilla/preferences-rev.xml           
<?xml version="1.0"?>                                                               

<!DOCTYPE bindings SYSTEM "chrome://global/locale/preferences.dtd">

<bindings id="mozilluxPreferencesBindings"
   xmlns="http://www.mozilla.org/xbl"     
   xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
   xmlns:xbl="http://www.mozilla.org/xbl">                                  

  <binding id="prefwindow"
           extends="chrome://global/content/bindings/preferences.xml#prefwindow">
    <content xul:dlgbuttons="accept,cancel" xul:persist="lastSelected screenX screenY"
             xul:closebuttonlabel="&preferencesCloseButton.label;"
             xul:closebuttonaccesskey="&preferencesCloseButton.accesskey;"
             xmlns:xhtml2="http://www.w3.org/TR/xhtml2"
             xmlns:wairole="http://www.w3.org/2005/01/wai-rdf/GUIRoleTaxonomy#"
             xhtml2:role="wairole:dialog"
             xul:title="&preferencesDefaultTitleMac.title;">
      <xul:radiogroup anonid="selector" orient="horizontal" class="paneSelector chromeclass-toolbar"
                      xhtml2:role="wairole:list"/> <!-- Expose to accessibility APIs as a list -->
      <xul:hbox flex="1" class="paneDeckContainer">
        <xul:deck anonid="paneDeck" flex="1">
          <children includes="prefpane"/>
        </xul:deck>
      </xul:hbox>
      <xul:hbox anonid="dlg-buttons" class="prefWindow-dlgbuttons"
                >
        <xul:button dlgtype="disclosure" class="dialog-button" hidden="true"/>
        <xul:button dlgtype="help" class="dialog-button" hidden="true" icon="help"/>
        <xul:button dlgtype="extra2" class="dialog-button" hidden="true"/>
        <xul:button dlgtype="extra1" class="dialog-button" hidden="true"/>
        <xul:spacer anonid="spacer" flex="1"/>
        <xul:button dlgtype="accept" class="dialog-button" icon="accept"/>
        <xul:button dlgtype="cancel" class="dialog-button" icon="cancel"/>
      </xul:hbox>
      <xul:hbox>
        <children/>
      </xul:hbox>
      <xul:keyset>
        <xul:key anonid="keyClose" key="&windowClose.key;" modifiers="accel" oncommand="window.close();"/>
      </xul:keyset>
    </content>
  </binding>
</bindings>
So they inject this code. That makes this bug invalid but please inform the author of the theme so it can be fixed. Thanks!
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
Yes, author reply with

Anyway, for the next version I've remove the button-order setting code for Firefox >=3.5

Today is out new version
You need to log in before you can comment on or make changes to this bug.