497379 - make "Open Containing Folder" available during download already

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, enhancement)

Description

[Rolf Bode-Meyer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.9.1pre) Gecko/20090610 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090610 SeaMonkey/2.0b1pre

I'd find it a great help if "Open Containing Folder" in the DLM would already be available during download. That way I'd have to wait until download is finished for opening the folder.

Reproducible: Always

Comment 1

[Daniel B.]

I agree.

SeaMonkey provides the feature of taking the user to the directory 
(folder) selected for the download.  (The user does not have to specify
the directory a second time (e.g., navigating to it in the file browser)
after specifying it when specifying where to save the downloaded file.

Unfortunately, SeaMonkey only provides that feature (enables the "Open
Containing Folder menu item) _after_ the download is complete, even 
though the user might want to go to that directory before the download 
is complete.

Remember than opening the downloaded file is not the only thing the
user might want to do with/in that download directory--the user might 
want to do something that does _not_ need to wait until the download 
is complete.

For example, after starting to download a file, I wanted to go (in 
the file browser) to the chosen download directory to create a
Windows shortcut to the web page that had the download link on it.  
Another example would be going to that directory to start cleaning 
out old versions of downloaded file while waiting for the current 
download to complete.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Confirming RFE, though I'm not sure a patch would receive a positive review: After all the label reads "Open Containing Folder", and the download is only contained in that folder once it finishes (but maybe a temp file is stored there during download). Anyway, that nit might just need an additional label change then.

Comment 3

[Christian Eyrich]

Attachment: Patch with two small changes to solve this bug.

Regarding comment 2, I don't see the need for changing the label because the files are indeed contained in the folder when the menu entries are available since the the code checks for exists() first.

Comment 4

[Philip Chee]

Comment on attachment 714799 [details] [diff] [review]
Patch with two small changes to solve this bug.

You need to set the review flag to someone specific. Otherwise nobody will notice that a review has been requested.

Comment 5

[[e-mail]]

Comment on attachment 714799 [details] [diff] [review]
Patch with two small changes to solve this bug.

r=me if you amend or remove the comment since it no longer applies.

Comment 6

[Christian Eyrich]

Attachment: Removed comments. r=Neil

Removed comments completely because it should be obvious why Open isn't available for a running download.

Comment 7

[Philip Chee]

Comment on attachment 716150 [details] [diff] [review]
Removed comments. r=Neil

Thanks. Do you require assistance to get this patch checked-in to the tree? Or do you have commit rights?

Comment 8

[Christian Eyrich]

No, I don't have commit rights. Would be great if you would check it in for me.

Comment 9

[Robert Kaiser]

Comment on attachment 716150 [details] [diff] [review]
Removed comments. r=Neil

Review of attachment 716150 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a fan of doing things this way at all, but I gave up ownership of download manager a long time ago.

Comment 10

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/05066341d74c

Thank you Christian!