497446 - [Extension] can't log out

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Dietrich Ayala (:dietrich)]

go to Collector prefs, click logout, nothing happens.

in js console:

Error: Bandwagon is not defined
Source File: chrome://bandwagon/content/ui/collectionsPaneController.js
Line: 276

Comment 1

[Dave Garrett]

What's your Add-on Collector extension version? Update to 1.0.2 if you haven't already.

Comment 2

[Dietrich Ayala (:dietrich)]

yes, running 1.0.2 on:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090610 Shiretoko/3.5pre

Comment 3

[Brian King [:kinger]]

Dave, note the user agent version.

See also bug 497438 that Dietrich filed, which might be related.

Comment 4

[David McNamara [:mackers]]

I don't think user version is relevant in this case - I can reproduce intermittently.

This is related to the odd error we've been seeing - "Error: Bandwagon is not defined" - in various incarnations, but only on Mac.

I think this may be something that happens when we lose a reference to the Bandwagon singleton in cases when the browser window itself is closed under certain circumstances.

I'll do a review on Mac and see if I can come up with a solid STR and solution.

Comment 5

[David McNamara [:mackers]]

STR on mac:

1. Start firefox.
2. Tools -> Add-ons
3. Close browser window (leaving add-ons open)
4. Re-open a browser window (leaving add-ons open)
5. In Add-ons window, some operations fail.

As I said, this was a symptom of a larger problem where the extension loses a reference to the Bandwagon namespace (and also Components, etc).

I have fixed this. Rather than relying on the global Bandwagon object being around, the extension is now keeping an internal reference to Bandwagon (and Components) which is "passed around". This and some other changes (w.r.t this bug) should finally resolve this "can't log out" problem and hopefully all related "Error: Bandwagon is not defined" problems.

r28006.


r

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the STR in comment 5, above, on:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 with the http://people.mozilla.com/~jscott/bandwagon/2009-08-11.xpi version of the add-ons collector.