497879 - [HTML5][Patch] HTML5 parser fails test_nsIAccessibleHyperLink.html

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Henri Sivonen (:hsivonen)]

http://mxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/test_nsIAccessibleHyperLink.html
fails. endIndex is off by a bit in some cases.

Comment 1

[Henri Sivonen (:hsivonen)]

1673 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID noLink! - got 255, expected 254
1674 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID noLink! - got 256, expected 255
1684 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID linkWithClick! - got 294, expected 292
1685 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID linkWithClick! - got 295, expected 293
1694 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID linkWithTitleNoNameFromSubtree! - got 347, expected 344
1695 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID linkWithTitleNoNameFromSubtree! - got 348, expected 345
1704 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID linkWithTitleNameFromSubtree! - got 397, expected 393
1705 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID linkWithTitleNameFromSubtree! - got 398, expected 394
1714 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID linkWithTitleNameFromImg! - got 452, expected 447
1715 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID linkWithTitleNameFromImg! - got 453, expected 448
1724 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong startIndex value for ID linkWithLabelNoNameFromSubtree! - got 456, expected 450
1725 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/a11y/accessible/test_nsIAccessibleHyperLink.html | Wrong endIndex value for ID linkWithLabelNoNameFromSubtree! - got 457, expected 451

Comment 2

[Henri Sivonen (:hsivonen)]

What do the startIndex and endIndex refer to?

I notice couple of oddities in the test file:
 1) End tag </img> (ignored by the HTML5 parser)
 2) End tag </br> (turns into <br> in the HTML5 parser)

Also, I notice that the test markup tries to avoid inter-element whitespace. However, the whitespace between </body> and </html> and the whitespace after </html> gets hoisted into body by the HTML5 parser.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #2)
> What do the startIndex and endIndex refer to?

I had to look this up actually.

startIndex is the offset of the link within the parent accessible.

endIndex is the end index of the link within the parent accessible, but because the link is represented by one embedded character within the parent text, it ends up being startIndex + 1.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

I'm not sure what to make of the failures in comment 1. Any thoughts why the offsets would change when the html5 parser is used?

Comment 5

[Henri Sivonen (:hsivonen)]

</br> causes badness, since it gets eaten by the old parser.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Good point, are you editing the test?

Comment 7

[Henri Sivonen (:hsivonen)]

I'm editing it, but my edit cycle will be slow, since the tryserver is part of the cycle.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Yeah, note this might work for you: python runtests.py --a11y (assuming your mozconfig is setup for tests)

Comment 9

[Henri Sivonen (:hsivonen)]

Attachment: Remove bogus end tags of void elements

Comment 10

[Henri Sivonen (:hsivonen)]

http://hg.mozilla.org/mozilla-central/rev/f8b8f2f214d6