498145 - Thunderbird can get into a state where account central shows up for every folder

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

I've noticed two things that are probably related:

1) When switching to an IMAP folder that is empty, account central briefly shows up. This is probably best seen just after startup when you're still opening connections etc, but it does it every time I enter an empty IMAP folder.

2) If you catch it just right, and I believe fast switching of folders on gmail IMAP (probably because its a slightly bigger delay for me) triggers it, then you can get Thunderbird into a state where it will show account central for *any* folder.

Opening a folder in a new tab at this time gives you normal behaviour.


Nothing useful in error console.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090613 Lightning/1.0pre Shredder/3.0b3pre

Comment 1

[Eric Moore]

I ran into a similar problem with the 20090613 Shredder nightly build under Vista home premium SP1 after dragging and dropping a message to a folder and selecting a folder that had messages in it. 

The main difference is that besides displaying account central whenever I selected a folder it also changed the server directory in tools -> account settings -> server settings -> advanced to [Gmail] in every IMAP account and saved that change in prefs.js. I had no problem removing that change.

Comment 2

[Jay Moran (jaym/lazvon)]

Same as Mark's #1 for me. Haven't seen #2 (Exchange IMAP on Corp LAN <1ms away) or Eric's scenario. 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090615 Shredder/3.0b3pre

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Same as Mark's #1 for me. Haven't seen #2 (Exchange IMAP on Corp LAN <1ms away)
> or Eric's scenario. 

With my ISP's IMAP server it is much harder to reproduce than with gmail.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to comment #0)
> 1) When switching to an IMAP folder that is empty, account central briefly
> shows up. This is probably best seen just after startup when you're still
> opening connections etc, but it does it every time I enter an empty IMAP
> folder.

This was sortof intentional, but not really.  Per the legacy code, we do not enter some folders[1] until a call to updateFolder completes.  The old code used to leave the previous view displayed through this 'limbo' time, but because of our normalized control flow and invariants, we end up displaying account central.

I expect we can probably get away with entering empty IMAP folders early and should do so.  The account central thing is probably fine for the dubious mail.password_protect_local_cache pref.

1:
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/dbViewWrapper.js#922

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Attachment: do not let view update depth get out of wack v1

This only handles Standard8's 2nd case.  The 1st needs to be spun off into its own bug.

The view update depth would get above 0 if you switch folders before the FolderLoaded notification showed up.  Then you would never ever see a view again.  The patch addresses this in multiple ways, adds some documentation, and a unit test.

Comment 8

[David :Bienvenu]

Comment on attachment 383828 [details] [diff] [review]
do not let view update depth get out of wack v1

this definitely fixes the quick selection of imap folders case

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

pushed: http://hg.mozilla.org/comm-central/rev/7b0473b45719

Standard8's first point has been spun off to bug 499069, which depends on changes bienvenu is making on bug 499064 to support immediate folder entry.

Comment 10

[Mark Banner (:standard8)]

Verifying that I can't make account central stay on the screen any more.

Comment 11

[trahloc]

Perhaps this fix caused an unintended bug with date based Sorts?

https://bugzilla.mozilla.org/show_bug.cgi?id=499238