499326 - Focus rings always have the same color no matter which background color is used on the web page

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[u88484]

STR:

1) Go to http://home.ingdirect.com
2) Click one of the image buttons on at the top left (view my account, open an account, or learn more)
3) A focus ring appears around the image and the focus ring flashes an orange color for a split second

Screencast: http://screencast.com/t/eXWw7JotV7

See this with even Firefox 3.0.11 so not a regression or at least a recent one.  Might even be a tech evangelism bug.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I still cannot see this problem on OS X  and Windows. Can you please add your build id so we know on which OS you are working?

Comment 2

[u88484]

I can reproduce using 3.0.11, 3.5 RC1 and latest (20090619) trunk on Vista.

Comment 3

[u88484]

Attachment: reduced test case

Also, a better screencast: http://screencast.com/t/iON6h1tsH9

Comment 4

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.11) Gecko/2009060215
Firefox/3.0.11
Happens in 3.0 as well. I think it's correct though, the background color is
blue so the inverted color would be orange...

Comment 5

[u88484]

(In reply to comment #4)
> Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.11) Gecko/2009060215
> Firefox/3.0.11
> Happens in 3.0 as well. I think it's correct though, the background color is
> blue so the inverted color would be orange...
It is always orangish/red no matter what the background color is.  Change the background color in the test case to pink or white and the focus ring is always red.  BTW, is there anyway to make the focus ring thicker?

Comment 6

[Nochum Sossonko [:Natch]]

The focus ring is controlled by firefox afaict, the style is something like:

a:focus {
  outline: 1px solid <some style that inverts the color>;
}

See bug 435697 for the equivalent button styling.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Always red focus ring

We really use the red focus all the time. There is no inverted color used.

Comment 8

[Nochum Sossonko [:Natch]]

It's set here:

http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp?mark=2269-2305#2267

Not sure why, though. The color is: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresContext.cpp#220

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is a regression during the development of Firefox 3.0. Testing Firefox 2.0.0.20 we have different colors for focus rings depending on the background color.

Comment 10

[(mostly gone) XtC4UaLL [:xtc4uall]]

ok, i did some digging:

between 1.9a1: 2006041705 & 1.9a1: 2006041810
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-17+05%3A00&maxdate=2006-04-18+10%3A00&cvsroot=%2Fcvsroot

the testcase from comment 3 changes using white color to dark (none visible?) for the dots.
[if you set "background-color: yellow;" you can see white dots though]
=> my wild guess: Bug 287813

between 1.9a1: 2006042404 & 1.9a1: 2006042505
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-04-24+04%3A00&maxdate=2006-04-25+05%3A00&cvsroot=%2Fcvsroot

it changes again, from above behavior to the current (always using red dots)
=> my wild guess: Bug 326550

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Xtc4UaLL! That's great work. Lets ask Masayuki or Roc if it is a regression from bug 326550.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It must be.

Comment 13

[Martijn Wargers (dead)]

Isn't this basically bug 359497?

Comment 14

[roxleitan]

20160502172042 Mozilla/5.0 (Windows NT 10.0; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

I could not reproduce the issue.
Setting the status to RESOLVED WORKSFORME.
If anyone can still reproduce it, feel free to reopen the issue and provide more information.
Thanks