Closed Bug 499916 Opened 15 years ago Closed 15 years ago

PleaseAlloc() is not returning NULL when requesting more memory than the heaplimit

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: brbaker, Assigned: treilly)

Details

Attachments

(1 file, 2 obsolete files)

minor update to pleaseAlloc() tests
5.92 KB, patch
brbaker
: review+
treilly
: review-
Details | Diff | Splinter Review
Attached patch PleaseAlloc selftest (obsolete) — — Splinter Review 
Setting the heaplimit to a low amount and then requesting a memory allocation that is larger than the heaplimit via GC::PleaseAlloc() should return NULL, however the the allocation is happening, GC::Size() is reporting that the size of the buffer is the size that was requested.
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Attached patch v2. Selftest for PleaseAlloc() (obsolete) — — Splinter Review 
If I add an additional PleaseAlloc() selftest to the end of the ST_mmgc_basic.st then I will actually see an "out of memory" error and the shell will exit with 128 exitcode.
Attachment #384605 - Attachment is obsolete: true
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x
changeset:   2048:ea1cfc4f4c4c
tag:         tip
user:        Tommy Reilly <treilly@adobe.com>
date:        Wed Jun 24 13:03:49 2009 -0400
summary:     Fix typo kCanFail->GCHeap::kCanFail
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

        Attachment #384609 -
        Attachment is obsolete: true

        Attachment #390248 -
        Flags: review?(brbaker)

    
  

        Attachment #390248 -
        Attachment is patch: true

        Attachment #390248 -
        Attachment mime type: application/octet-stream → text/plain

    
  

        Attachment #390248 -
        Flags: review?(brbaker) → review+

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
Dan looks like this patch was never submitted (from comment #3)

    
    

    
  
Comment on attachment 390248 [details] [diff] [review]
minor update to pleaseAlloc() tests

Dan, still looks like this has never made it it. Can you rebase/retest your patch?

    
  

        Attachment #390248 -
        Flags: review?(treilly)

    
    

    
  
does this need a new testcase?  tommy to review?  in-testsuite? incompatible with verified/fixed.

    
    

    
  
Comment on attachment 390248 [details] [diff] [review]
minor update to pleaseAlloc() tests

invalid to call DumpMemoryInfoLocked w/o first obtaining the heap lock

invalid to set heapLimit below initialSize, we should enforce that but we don't

        Attachment #390248 -
        Flags: review?(treilly) → review-

    
  
QA Contact: gc → dschaffe

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: