501027 - Restart tests sometimes don't shutdown the browser

Status: RESOLVED WORKSFORME

(Testing Graveyard :: Mozmill, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While implementing the extension installation test in bug 500419 I have noticed that sometimes the browser is not closed after the test has been finished. I hangs around and no further test will be processed.

Killing the browser and the Python process will give the following output inside the console:

Traceback (most recent call last):
  File "/usr/local/bin/mozmill-restart", line 8, in <module>
    load_entry_point('mozmill==1.2b1', 'console_scripts', 'mozmill-restart')()
  File "/Volumes/data/build/mozmill/trunk/mozmill/__init__.py", line 388, in restart_cli
    RestartCLI().run()
  File "/Volumes/data/build/mozmill/trunk/mozmill/__init__.py", line 375, in run
    super(RestartCLI, self).run(*args, **kwargs)
  File "/Volumes/data/build/mozmill/trunk/mozmill/__init__.py", line 348, in run
    self.options.report)
  File "/Volumes/data/build/mozmill/trunk/mozmill/__init__.py", line 285, in run_tests
    self.run_dir(d, report, sleeptime)
  File "/Volumes/data/build/mozmill/trunk/mozmill/__init__.py", line 253, in run_dir
    sleep(.25)

Looks like mozmill.endRunner is never fired?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

How complex will a patch for this shutdown issue look like? Can we somehow get a fix for MozMill 1.2 so we can reliable run restart tests? It's really sporadic for me when it works and when it doesn't work.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just run the test on bug 500419 a couple of times. For me it breaks after the 3rd or 4th run.

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

I'm not seeing this behavior, I just ran the restart tests 50 times (which is nearly a thousand restarts) and none of them stalled.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I cannot run my mentioned test with the latest changes due to not working menu clicks. We have to wait until this has been fixed.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Haven't seen this for a while. Lets close it out for now.