501159 - Trailing comma in tag is retained

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: comma

steps to reproduce:
1.Log in to your AMO account.
2.Navigate to any add-on page
3.Click on "Add a atg" link
4.Enter "test,blah," as tags and click add

expected result:
the redundant trailing comma is ignored

actual result:

Comma is also saved(see attached image)

Comment 1

[Wil Clouser [:clouserw]]

I had the idea that  we should whack this along with trim()ing the tags, but making a special case for commas over other punctuation seems lame.  ->wontfix

Comment 2

[Wil Clouser [:clouserw]]

we're delimiting on commas ->reopen

Comment 3

[Wil Clouser [:clouserw]]

This is already fixed, right?

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> This is already fixed, right?

Looks like this bug has turned into "trailing comma adds a blank tag" - for the record, a tag should never be blank.  Just make the split function remove anything that is blank.

Comment 5

[Yem Huynh]

Attachment: fix

ignore empty spaces. so the following:

,aaa,  ,bbb,  ,,,cccc,

will only create tags:

aaa
bbb
ccc

Comment 6

[Wil Clouser [:clouserw]]

A similar patch is committed in r29326

Comment 7

[krupa raj[:krupa]]

verified