501166 - Fatal PHP error on editor performance charts

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Scott McCammon [:mccammos]]

This appears to be a regression from the merge with Webmocha tagging.

Notice: Undefined property: EditorsController::$Tag in /home/smccammon/public_html/communication-fix2-495491/site/app/controllers/editors_controller.php on line 850

Fatal error: Call to a member function unbindFully() on a non-object in /home/smccammon/public_html/communication-fix2-495491/site/app/controllers/editors_controller.php on line 850

Comment 1

[Scott McCammon [:mccammos]]

Attachment: Fix

Updated all references to the old Tags table/model to Categories in the editors controller.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 385788 [details] [diff] [review]
Fix

thanks

Comment 3

[Scott McCammon [:mccammos]]

fix in r28908

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/editors is a 404; does some SQL need to be run on preview to fix this?

Comment 5

[Tom Ellins [:TMZ]]

Fine for me ( https://preview.addons.mozilla.org/en-US/firefox/users/login?to=en-US%2Feditors )

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Fine for me (
> https://preview.addons.mozilla.org/en-US/firefox/users/login?to=en-US%2Feditors
> )

Yeah, it was fixed by some Cake model cache or SQL run, or something.

Rey, can you verify on https://addons.mozilla.org/en-US/editors/performance?  Thanks!

Comment 7

[Rey Bango]

Works perfectly. :)