Closed
Bug 501428
Opened 15 years ago
Closed 15 years ago
Optimize CalcBezier
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
513 bytes,
patch
|
dholbert
:
review+
longsonr
:
review+
|
Details | Diff | Splinter Review |
I was looking through the SMIL code and saw an inefficient implementation of CalcBezier(). This patch eliminates the call to pow() and reduces the number of multiplications from 4 to 3.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #386067 -
Flags: review?(dholbert)
|
||
Updated•15 years ago
|
Attachment #386067 -
Flags: review?(dholbert) → review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 386067 [details] [diff] [review] Optimize nsSMILKeySpline::CalcBezier Looks like you're just factoring out some "aT" multiplicands, to reduce the total number of multiplications -- looks good to me. (You may also need review from an SVG peer, though -- jwatt, longsonr, or roc)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #386067 -
Flags: review?(jwatt)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #386067 -
Flags: review?(jwatt) → review?(longsonr)
|
||
Updated•15 years ago
|
Attachment #386067 -
Flags: review?(longsonr) → review+
|
|
||
Updated•15 years ago
|
Assignee: nobody → jmuizelaar
|
|
||
Comment 3•15 years ago
|
||
Jeff landed this bug's patch earlier today. Resolving. http://hg.mozilla.org/mozilla-central/rev/585d2a1d511c
OS: Mac OS X → All
Hardware: x86 → All
|
|
||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•