Closed
Bug 501786
Opened 15 years ago
Closed 15 years ago
fold nsIPluginInstanceInternal into nsIPluginInstance
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
20.56 KB,
patch
|
Details | Diff | Splinter Review |
We should remove nsIPluginInstanceInternal, fold it into nsIPluginInstance.
Attachment #386356 -
Flags: superreview?(jst)
Johnny - I'm particularly interested in what you have to say about "nsHTMLPluginObjElementSH::NewResolve". Seems like we can remove a lot of that.
Comment 2•15 years ago
|
||
Comment on attachment 386356 [details] [diff] [review] fix v1.0 PluginWndProc() (in nsPluginNativeWindowWin.cpp): + if (inst && !nsVersionOK(inst->GetPluginAPIVersion(), NP_POPUP_API_VERSION)) That doesn't compile, needs to be something like: PRUint16 version; inst->GetPluginAPIVersion(&version); if (inst && !nsVersionOK(version, NP_POPUP_API_VERSION)) inst->PushPopupsEnabledState(PR_TRUE); r+sr=jst
Attachment #386356 -
Flags: superreview?(jst)
Attachment #386356 -
Flags: superreview+
Attachment #386356 -
Flags: review+
Windows build fix, update to current trunk.
Attachment #386356 -
Attachment is obsolete: true
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/d100ce57eb76
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Keywords: dev-doc-needed
Updated•15 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
Summary: remove nsIPluginInstanceInternal → fold nsIPluginInstanceInternal into nsIPluginInstance
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•