501864 - Symbian emulator should defines as i386, not ARM.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Makoto Kato [:m_kato]]

Attachment: patch v1

Symbian emulator (WINS / WINSCW) is i386 architecture, not ARM.  But current NSPR defines as ARM.  It should not define as it.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 386437 [details] [diff] [review]
patch v1

After reviewing the patch, I see that the issue here is *not* with any symbol
that is defined (definition is created) by NSPR, but rather the issue is 
that NSPR only tests for the presence of __WINS__ when __arm__ is also defined, 
rather than treating those symbols as mutually exclusive.

The patch changes the behavior so that effectively __WINS__ is an alternative 
to, and mutually exclusive with, __arm__.  Since this change only affects 
files that that are only built in symbian builds, I have no objection to 
this change.  r=nelson

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

pr/include/md/_symbian.cfg; new revision: 1.4; previous revision: 1.3
pr/include/md/_symbian.h;   new revision: 1.2; previous revision: 1.1