501889 - _scheduletimer symbol not found on Solaris

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ginn Chen]

2494 uint32_t NP_CALLBACK
2495 _scheduletimer(NPP instance, uint32_t interval, NPBool repeat, void (*timerFunc)(NPP npp, uint32_t timerID))

It doesn't match the header. We need to use extern "C" for the function pointer.

The compiler gives a warning.
"../../../../../modules/plugin/base/src/nsNPAPIPlugin.cpp", line 2497: Warning: function unsigned(_NPP*,unsigned,unsigned char,void(*)(_NPP*,unsigned)) overloads extern "C" unsigned(_NPP*,unsigned,unsigned char,extern "C" void(*)(_NPP*,unsigned)) because of different language linkages.
1 Warning(s) detected.

And
nm nsNPAPIPlugin.o | grep _scheduletimer | c++filt 
[252]   |     24192|        59|FUNC |GLOB |2    |38     |unsigned _scheduletimer(_NPP*,unsigned,unsigned char,void(*)(_NPP*,unsigned))
[126]   |         0|         0|FUNC |GLOB |0    |UNDEF  |_scheduletimer

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Josh Aas]

So this needs to be extern c because it has a function pointer as an argument? Whatever the reason, can you document it in the patch?

Comment 3

[Ginn Chen]

Yes, I will do that.

Comment 4

[Ginn Chen]

Comment on attachment 386460 [details] [diff] [review]
patch

Josh, can you review the patch?

We need to get tinderbox and nightly builds back ASAP.

Comment 5

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/a5d066920368

Comment 6

[Benjamin Smedberg]

In the electrolysis branch I removed the extern "C" block as part of bug 532605, followup to bug 526401: now none of the declarations or definitions are extern-C, and are contained in a c++ namespace for unambiguous mangling.

Comment 7

[Ginn Chen]

electrolysis builds fine on Solaris with --enable-libxul --disable-ipc, except content/base/src/nsFrameLoader.cpp includes "mozcontainer.h" <gdk/gdkx.h> <gtk/gtk.h>, but hasn't proper -I in Makefile.
I deleted these #include lines and it worked.

However, it seems it's not easy to port electrolysis to Solaris and Sun Studio compiler.
I meant a lot of problems with STL.