Closed
Bug 502137
Opened 15 years ago
Closed 15 years ago
Remove dead plugin scripting code.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: jst, Assigned: jst)
References
Details
Attachments
(1 file)
|
5.46 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
Now that we no longer support XPCOM plugins there's some code in nsDOMClassInfo.cpp that no longer does anything useful. See attached patch.
Attachment #386651 -
Flags: superreview?(mrbkap)
Attachment #386651 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•15 years ago
|
||
Oh, and this patch also adds an ObjectIsNativeWrapper() check to nsHTMLPluginObjElementSH::Call(), since I think that's what we want to do there...
|
||
Comment 2•15 years ago
|
||
Comment on attachment 386651 [details] [diff] [review] Remove dead code. The world just got a little bit brighter.
Attachment #386651 -
Flags: superreview?(mrbkap)
Attachment #386651 -
Flags: superreview+
Attachment #386651 -
Flags: review?(mrbkap)
Attachment #386651 -
Flags: review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Fixed, and I updated the comment about the prototype layout before and after we script a plugin as well... http://hg.mozilla.org/mozilla-central/rev/457417981271
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Version: unspecified → Trunk
|
||
Comment 4•15 years ago
|
||
Thanks to Daniel we were able to see that the removal has also been affected NPAPI plugins. The regression is covered on bug 524649.
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•