502262 - "Return to the compose window" is a yes/no question

Status: UNCONFIRMED

(Thunderbird :: Message Compose Window, defect)

Description

[Alex]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.11) Gecko/2009060309 Ubuntu/9.04 (jaunty) Firefox/3.0.11
Build Identifier: version 2.0.0.22 (20090608)

When sending a message, you are sometimes asked "Would you like to return to the compose window?", and given the options "Cancel" and "OK". The options should be "No" and "Yes".

Reproducible: Always

Steps to Reproduce:
1. Start sending a message
2. Cancel the send dialog when it starts copying to the sent mail folder
3. When asked about retrying, hit cancel (which should probably be "Don't retry" and "Retry", but...)
4. The next dialog asks "Would you like to return to the compose window?", with options "Cancel" and "OK".
Actual Results:  
The dialog asks "Would you like to return to the compose window?", with options "Cancel" and "OK".

Expected Results:  
The next dialog asks "Would you like to return to the compose window?", with options "No" and "Yes".

Comment 1

[Liscare]

This dialog doesn't seem to exist anymore. On Daily (92.0), at the step 3, you return to the compose window if you choose "Save". If you choose "Don't save", you will not return to the compose window.
This bug can be marked as Resolved Invalid.

Comment 2

[Thomas D. (:thomas8)]

Hi Lilian, thank you for looking into this! The dialog is still existing, so it's unlikely to be invalid. Here's how I checked:

1. As we know the exact string from comment 0, and it does not seem to contain any variables like sizes, brand name, item names etc., we can just search for the full exact string (en-US only):
   https://searchfox.org/comm-central/search?path=&q=Would%20you%20like%20to%20return%20to%20the%20compose%20window
   This search finds the string with string ID.

2. Run another search on the string ID returnToComposeWindowQuestion to see if it still used in code:
   https://searchfox.org/comm-central/search?q=returnToComposeWindowQuestion&path=

3. From search result (3 matches), mail or mailnews matches are relevant for Thunderbird (suite is SeaMonkey):
   https://searchfox.org/comm-central/source/mailnews/compose/src/nsMsgSendReport.cpp#332
   So we have found the spot in code where this string is still used. From there, you will be able to check if it is still Yes/No.
   To change the last link into a permalink, click anywhere in the code to put focus there, then press y to change URL to permalink:
   https://searchfox.org/comm-central/rev/5da2b3f7e2e6eda21a7dcb901e1ba4400dea310b/mailnews/compose/src/nsMsgSendReport.cpp#332