502516 - Cannot use file picker to browse for folders on Windows CE

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P4)

Description

[Justin Dolske [:Dolske]]

The "Browse" button on the General prefs pane (for selecting a download location) does nothing on Windows CE. Clicking it should bring up a file picker for selecting a download folder.

I think this might not be implemented in the widget code... widget/src/windows/nsFilePicker.cpp ::ShowW() has a block at the top for "if (mMode == modeGetFolder)", which is #ifdef's out for WinCE. I suspect this is what's used for picking a folder, but didn't verify that.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I'm testing something right now, but basically it looks like you're right... Specifically we use functions and structs with a W at the end, which can be taken off for CE and work (I think).

That's not specific to here. I'm not sure why we do this, but somebody with more Windows programming experience could probably say.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Works. I don't know where else we do it, but you can test it in Options -> General -> Browse

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Taras tested on winmo & it doesn't build there. So it looks like instead of getting rid of the #ifndefs I'll just change them to #ifndef WINCE_WINDOWS_MOBILE

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yep, as per:

http://msdn.microsoft.com/en-us/library/aa923860.aspx

not supported on Windows Mobile.

(WinMo is actually based on CE5, not CE6, at least until they unify with CE7)

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2

I played with the other #ifdefs but no luck. It was just additional error handling, so oh well.

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

pushed http://hg.mozilla.org/mozilla-central/rev/b11fc38bb6ae

Comment 7

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; WindowsCE 6.0; en-US; rv:1.9.2.a2pre)
Gecko/20090818 Namaroka/3.6a2pre.   The textarea for the download location is still transparent, instead of showing up white though.