502759 - MobileNightlyRepackFactory doesn't clobber ever

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

Not sure what I expected it to do.

BaseRepackFactory has a hardcoded |rm -rf dist/upload| and |rm -rf dist/update| but MobileNightlyRepackFactory just scp's a glob from dist/.  When the binaries change names, it uploads the old+new.

Move BaseRepackFactory's rm commands to an addPreCleanSteps() method and override in MobileNightlyRepackFactory.

Comment 1

[Axel Hecht [:Pike]]

The glob upload doesn't work all to well anyway, I'm adding an l10n-upload-% target as part of bug 490482 to use upload.py instead and given package names.

Patch there should be ready soon.

Not sure how much we actually have in dist/upload or dist/update in the Firefox case, I read the build logs to upload from dist and dist/install. Coop, Armen?

Comment 2

[Aki Sasaki (not active)]

Fixed in bug 511889 for reasons only known to myself.