Closed Bug 503090 Opened 15 years ago Closed 15 years ago

Changing ARM architecture requires editing header file

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
ARM
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: tomd, Assigned: rreitmai)

Details

(Keywords: arch)

Attachments

(1 file)

proposed patch
395 bytes, patch
rreitmai
: review+
edwsmith
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/530.5 (KHTML, like Gecko) Chrome/2.0.172.33 Safari/530.5
Build Identifier: tamarin-redux 1.4 2009-07-08 

It is currently necessary to edit nanojit/NativeARM.h to generate ARMv6 or ARMv7 instructions instead of ARMv5 instructions. This should be a compile-time option.

Reproducible: Always
Attached patch proposed patch — — Splinter Review 

    
  
Keywords: arch
Hardware: Other → ARM

    
    

    
  
Whatever approach we use here, let's surface it to nanojit clients as well; knowing we are ARMv6-or-later would allow other optimizations elsewhere (eg unaligned reads).

    
    

    
  
Tom needs this in the next TC merge.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

    
  

        Attachment #387460 -
        Flags: review?(rreitmai)

    
  

        Attachment #387460 -
        Flags: review?(rreitmai) → review+

    
  
Assignee: nobody → rreitmai
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → flash10.1

    
  

        Attachment #387460 -
        Flags: superreview?(edwsmith)

    
    

    
  
Can someone push this for Tom?

    
  

        Attachment #387460 -
        Flags: superreview?(edwsmith) → superreview+

    
    

    
  
pushed to redux as changeset:   2363:1925894aa227
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED

    
    

    
  
removing QRB request, bug verified
Flags: flashplayer-qrb?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: