503902 - back out (put back) DOM object access

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: put back NPNVDOMElement and NPNVDOMWindow

NPNVDOMElement and NPNVDOMWindow are used by the ActiveX plugin shim; we need for that shim to keep working, at least for the next release.  This code puts back support for those to nsNPAPIPlugin.cpp.

Comment 1

[Benjamin Smedberg]

Wow, why do you need the activex shim? And why does the activex shim need NPNVDomElement and such?

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #1)
> Wow, why do you need the activex shim?

We need it to get to Flash on Windows CE/Mobile, until they ship Flash 10 which will (hopefully) be NPAPI.

> And why does the activex shim need NPNVDomElement and such?

That I don't exactly know; it needed DOMDocument to grab the JSContext to do some JS-ery, and I didn't look into why it needed DOMElement.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 388247 [details] [diff] [review]
put back NPNVDOMElement and NPNVDOMWindow

I'm fine with putting this back to keep the current WinCE flash going, but I'd prefer to see us enable this *only* for WinCE so plugins on other platforms don't think these will remain in our tree. So r+sr=jst with the appropriate #ifdef and a comment explaining why this code exists only for WinCE.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/eb39efc134fb