503988 - mochitest-chrome: intermittent "test_bug298622.xul | find failed on second page loaded"

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Curtis Bartley [:cbartley]]

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247517827.1247519709.11850.gz

Comment 1

[Curtis Bartley [:cbartley]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1247505930.1247512916.30053.gz

Comment 2

[Curtis Bartley [:cbartley]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247509462.1247511151.10706.gz

Comment 3

[Curtis Bartley [:cbartley]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247532828.1247536583.2273.gz

Comment 5

[Boris Zbarsky [:bzbarsky]]

How's that bug a duplicate of the issue this was filed on?

Comment 6

[Curtis Bartley [:cbartley]]

(In reply to comment #5)
> How's that bug a duplicate of the issue this was filed on?

It's not.  I reopened it once I recognized my mistake.

Comment 7

[Jonathan Griffin (:jgriffin)]

Hmmm, this passes on my machine on trunk.  Boris, do you think it needs something like:

setTimeout(nextTest, 0);

between these two lines:

      enterStringIntoFindField("A generic page");
      ok(TestWindow.getWindow().getSelection().toString().toLowerCase() == 
         "a generic page",
         "find failed on second page loaded");


in order to allow the key events in enterStringIntoFindField() to be processed?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Thing is, it's not failing all the time.  Just sometimes, right?

I rewrote that test using is() instead of ok() so if it fails again we'll at least see what the value actually was....

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1247505930.1247512916.30053.gz

This run has two errors:
1158 ERROR TEST-UNEXPECTED-FAIL | ... | find failed on second page loaded
1164 ERROR TEST-UNEXPECTED-FAIL | ... | find failed on page loaded from bfcache

(In reply to comment #3)
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247532828.1247536583.2273.gz

This run does not have this bug!

Comment 10

[Jeff Muizelaar [:jrmuizel]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247673166.1247674925.3675.gz

Comment 11

[Jeff Muizelaar [:jrmuizel]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1247672568.1247676741.23616.gz

Comment 12

[Boris Zbarsky [:bzbarsky]]

From that last log:

1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page".

I wonder whether this is a matter of paint suppression or something...  I'll try doing something akin to comment 7 but _before_ we start typing in the textfield, and see how that goes.

Comment 13

[Makoto Kato [:m_kato]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1247819392.1247824031.26140.gz

Comment 14

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/53ea332fc166 per comment 12.  Let's see how it goes.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1248078360.1248083510.22242.gz
Linux mozilla-central unit test on 2009/07/20 01:26:00  
1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"
1164 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on page loaded from bfcache - got "", expected "find this"

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248074280.1248076135.8836.gz
Linux mozilla-central test everythingelse on 2009/07/20 00:18:00  
1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248090517.1248092183.22359.gz
Linux mozilla-central test everythingelse on 2009/07/20 04:48:37  
1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"
1164 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on page loaded from bfcache - got "", expected "find this"

Comment 17

[Benjamin Smedberg]

jgriffin could you please take a look at this? It's one of the larger causes of rando-orange causing pain on the mozilla-central tree.

Comment 18

[Boris Zbarsky [:bzbarsky]]

So we can try the suggestion from comment 7, but it really doesn't seem like that should be necessary.  Does anyone who know how the find impl in Firefox works want to take a look and see what's up here?

Comment 19

[Jonathan Griffin (:jgriffin)]

Attachment: mochitest update

I've added the check from comment 7, plus an additional check that the expected string is in the Find bar's input field.  Passes locally.  Can someone commit?  I don't yet have commit privileges.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Pushed Jonathan's patch as http://hg.mozilla.org/mozilla-central/rev/37d1aab5e078

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248260677.1248262533.3708.gz
Linux mozilla-central test everythingelse on 2009/07/22 04:04:37  
1159 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"

Comment 22

[Jonathan Griffin (:jgriffin)]

Attachment: another mochitest update

Here are two more test changes.  

1) use waitForTrue() to attempt to wait for the Find operation to successfully select text on the screen, in case the problem is that this is just very slow on some machines.

2) detect the case where Firefox loses focus when the test is running, which will cause this test to fail (Find won't select anything on the window if the window in question doesn't have focus).

Can someone push when they have a chance?

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248362050.1248364051.11801.gz
Linux mozilla-central test everythingelse on 2009/07/23 08:14:10  

1159 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"
1165 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on page loaded from bfcache - got "", expected "find this"

Comment 24

[Justin Lebar (not reading bugmail)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248377463.1248379694.31337.gz
Linux mozilla-central test everythingelse on 2009/07/23 12:31:03

1159 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"

--------------

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248386867.1248389018.7517.gz
Linux mozilla-central test everythingelse on 2009/07/23 15:07:47

1159 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"

Comment 25

[Boris Zbarsky [:bzbarsky]]

Pushed the patch from comment 22 as http://hg.mozilla.org/mozilla-central/rev/802c2be7e2e6

Comment 26

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Still having issues:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248561807.1248563479.17910.gz
Linux mozilla-central test everythingelse on 2009/07/25 15:43:27

1158 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | Timed out waiting for condition
1161 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/docshell/test/chrome/test_bug298622.xul | find failed on second page loaded - got "", expected "a generic page"

Comment 27

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Linux mozilla-central test everythingelse on 2009/07/27 11:12:07
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248718327.1248720606.4169.gz

Comment 28

[Jonathan Griffin (:jgriffin)]

Attachment: another mochitest update

OK, another attempt at a solution.  This version uses the find bar's internal methods for initiating the find, and verifies the find bar's internal status after the find is executed.  If this version still suffers sporadic failures, we may consider using mochitest's snapshot capability to detect whether the found text is selected, instead of getSelection().

Boris, can I bother you for another commit?

Comment 29

[Jonathan Griffin (:jgriffin)]

Attachment: another mochitest update [Checkin: Comment 30]

Fix an error in the last patch before committing.

Comment 30

[Jonathan Griffin (:jgriffin)]

Pushed the patch from comment 29 as http://hg.mozilla.org/mozilla-central/rev/37403bc90c4a

Comment 31

[Markus Stange [:mstange]]

The test has just failed with a different error message; I filed bug 508188.

Comment 32

[Jonathan Griffin (:jgriffin)]

I'm marking this as resolved, as this hasn't recurred in the ~3 weeks since the test fix was checked in.