504425 - Pages with no <title> look odd in new autocomplete window

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Previously, pages with no <title> looked like

[icon] http://page.with.no/title                           
[icon] http://page.with.com/title           My Awesome Page

i.e., a blank "title" column, which was OK since the leftmost column, where your eyes is drawn, was always populated and contained the important info.

In the new world, pages with no <title> look like

[icon]                                      http://page.with.no/title
[icon] My Awesome Page                      http://page.with.com/title

looks bad and is confusing, since the leftmost column containing the important info is now blank.

We should do something for these pages; suggestions include:

1) Safari apparently uses "(no title)"
2) We could put the full URL, like we do in the titlebar for these pages
3) We could just list the domain, "since it's the part users are most likely to know/understand"

Comment 1

[Dan Weber]

Attachment: Patch 1

This sets blank titles to the host. I think this makes the most sense out of the options so far because setting the title to the entire URL is just repeating information that is right there.

Comment 2

[Stuart Morgan]

Comment on attachment 389183 [details] [diff] [review]
Patch 1

>+    [info setTitle:[[NSURL URLWithString:[info url]] host]];

This will work in most cases, but not all; we've run into cases where bookmarks aren't actually NSURL-able; for example, bookmarklets, which have javascript:<a lot of javascript> sometimes aren't properly escaped, so URLWithString will give you nil. You'll need fallback logic to handle the nil case--probably just put the URL when that happens.

Comment 3

[Dan Weber]

Attachment: Patch 2

Comment 4

[Stuart Morgan]

Comment on attachment 389241 [details] [diff] [review]
Patch 2

>+    if (host)
>+      [info setTitle:host];
>+    else
>+      [info setTitle:[info url]];

Maybe more readable as just
  [info setTitle:(host ? host : [info url])];
? Your call though.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 389241 [details] [diff] [review]
Patch 2

sr=pink

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on cvs trunk with
 [info setTitle:(host ? host : [info url])];
per dan on irc.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Moving these bugs to the 2.1 milestone to make it easier for them to fall out of the rough "all bugs fixed for 2.0" query.