504579 - Add-on description and "Add to Firefox" button are hidden by the screenshot when window is too narrow

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090715 Shiretoko/3.5.1pre ID:20090715031842

With the default width of the main browser window the add-ons description and the "Add to Firefox" button are partly hidden by the screenshot. I found this problem today while running Mozmill with the extension installation script which fails now.

I don't think that the text and the button should be moved behind the screenshot when the window is too narrow.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There was a push yesterday, right?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> There was a push yesterday, right?

Yes; could you please attach a screenshot?  Thanks!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot

Comment 4

[Fred Wenzel [:wenzel]]

Is this a regression really? Looks to me like this wasn't introduced yesterday.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I don't have a chance to test with older AMO versions. The only thing I can say is that the Mozmill extension installation test fails since yesterday. It was fine when running the Smoketests on Wednesday (before the push).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> Is this a regression really? Looks to me like this wasn't introduced yesterday.

It's not really a regression. The breaking Mozmill script is a result of the DOM changes on AMO with the latest push. I've updated the script and it works fine.

So it's only a problem on smaller widths which is e.g. for the default window size after the Firefox installation.

Comment 7

[Jeff Balogh (:jbalogh)]

rdoherty offered to take this one, isn't he nice?

Comment 8

[Ryan Doherty (:rdoherty)]

Attachment: v1

I have no idea how this works, but it does!

Comment 9

[Jeff Balogh (:jbalogh)]

Comment on attachment 390084 [details] [diff] [review]
v1

Way to show off your mad CSS skillz!

Only one thing:

>Index: site/app/webroot/css/amo2009/main-mozilla.css
>===================================================================
>--- site/app/webroot/css/amo2009/main-mozilla.css	(revision 30256)
>+++ site/app/webroot/css/amo2009/main-mozilla.css	(working copy)
>@@ -761,6 +761,9 @@
> 
> #addon .featured .secondary {
>     margin-bottom: 0;
>+    width: 230px;
>+    display: block;
>+    float: left;

It looks like this part can be removed.

Comment 10

[Ryan Doherty (:rdoherty)]

r30301 , extra css removed.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ryan where can I test it?

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> Ryan where can I test it?

Always at https://preview.addons.mozilla.org/en-US/firefox/

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks. Works fine. Marking verified.