Closed
Bug 504934
Opened 15 years ago
Closed 15 years ago
Add explicit braces to if-statement, to fix build warning in nsContentBlocker.cpp
Categories
(Core :: Graphics: Image Blocking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.10 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
When building nsContentBlocker.cpp, I get this compile warning: /mozilla/extensions/permissions/nsContentBlocker.cpp: In member function ‘virtual nsresult nsContentBlocker::ShouldLoad(PRUint32, nsIURI*, nsIURI*, nsISupports*, const nsACString_internal&, nsISupports*, PRInt16*)’: /mozilla/extensions/permissions/nsContentBlocker.cpp:184: warning: suggest explicit braces to avoid ambiguous ‘else’ The attached patch adds explicit braces and fixes this warning.
Attachment #389201 -
Flags: review?(jst)
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
||
Updated•15 years ago
|
Attachment #389201 -
Flags: superreview+
Attachment #389201 -
Flags: review?(jst)
Attachment #389201 -
Flags: review+
|
|
Assignee | |
Comment 1•15 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/02ff5f05a1a6
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•