505044 - Selection lost when leaving a folder and coming back into it (mailnews.remember_selected_message doesn't work)

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Frédéric Buclin]

This was working fine with beta 2, so this is a regression in beta 3:

- Select a message in your list
- Go into another folder
- Come back to the first folder

The initially selected message should be redisplayed, but is not. The selection is lost.

Comment 1

[Mark Banner (:standard8)]

Potential duplicate of bug 497348.

Comment 2

[rsx11m]

Toggling mailnews.remember_selected_message doesn't make a difference, it is treated "false" in either case (testing 3.0b3 build on Linux).

The description for bug 497348 states:

> A server resync is performed, and _then_ the previously selected email is
> selected.

which is different (no mail is selected in this case at all). Also, I'm seeing this for both IMAP and local folders, thus independent of resyncing.

Comment 3

[Magnus Melin [:mkmelin]]

Very annoying regression indeed.

Comment 4

[Mark Banner (:standard8)]

Assigning to clarkbw for input - I think the core issue here is the same as per bug 497348 and we need a UX decision on what we are going to do here. The discussion on bug 497348 is especially worth a read.

Comment 5

[Wayne Mery (:wsmwk)]

I peg the regression range at 20090628-20090629 and likely makes the regressor one of sid0's bugs
* bug 467768 - No way to make mail open in tabs by default 
* Bug 500657 - open message from Search Messages results does not work well
The regression got shipped in beta 3 - which suggests we don't have any tests for this behavior. 

Unless you're someone who lives in one folder this is very dogfoodish, eg flipping folders or doing folder maintenance, which I was doing today in a big way. What saved me from going crazy was (ironically) tabs, because I could have a tab open for each folder I was working with.

Comment 6

[Rain [:rain1] (inactive)]

Yes, this was broken by bug 467768 -- <http://hg.mozilla.org/comm-central/diff/01bd846dbb7e/mail/base/content/folderDisplay.js#l1.55>. There were several problems because of this (mainly with multiple message loads on startup with tab persistence on and a few message tabs open), and asuth said that since we're going to be adding folder summaries, it would be fine if I remove that code.

If we decide to add it back we'll need to rework it to prevent multiple loads from happening at startup. It shouldn't be too hard I guess.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

In the folder summary - bug 492158 - designs we had planned to handle the previous selection inside the summary.  However the folder summary is not landing w/ TB3.0 so we'll need to figure out a way to bring this back.

sid, do you want to take this?

Comment 8

[Rain [:rain1] (inactive)]

Yep, I'll look at this.

Comment 9

[Rain [:rain1] (inactive)]

Attachment: reintroduce removed code

Seems like bug 498514 was the cause of all the grief, which means that all I needed to do was to reintroduce the code :)

Comment 10

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/1a6524fa578d

Comment 11

[Valery Kondakoff]

Can you, please, take a look at this issue as well: https://bugzilla.mozilla.org/show_bug.cgi?id=515301 ?

Thank you!

Comment 12

[Wayne Mery (:wsmwk)]

thanks sid
v.fixed with 20090908 build