505682 - nsSSLIOLayerHelpers::Init must rv check calls to hashtable Init

Status: RESOLVED INVALID

(Core :: Security: PSM, defect)

Description

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpcom/ds/nsDoubleHashtable.h&rev=3.17&mark=99,103-104,330#99

psm isn't checking the rv from Init here, that's a bug. (but it's unlikely to
be the cause of this crash...)

I wonder if someone could possibly explain why there are so many statics.

If there's no good reason to use statics, then we could probably do away with dynamic allocation for those two objects....

Comment 1

[timeless]

Attachment: and fix its caller...

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 389895 [details] [diff] [review]
and fix its caller...

bitrot and too much distracting noise in this patch

Comment 3

[Kai Engert (:KaiE:)]

adding brian and honza in case they want to work on this correctness cleanup

Comment 4

[:Cykesiopka]

Bug 734847 made nsTHashtable infalliable by default (and AFAICT nsNSSIOLayer.(h|cpp) don't use fallible ones) + Bug 910989 got rid of nsTHashtable::Init(), so there's nothing to do here anymore.