Closed
Bug 505750
Opened 15 years ago
Closed 15 years ago
Fix nsDOMStorage.cpp:CheckSecure code to not mask by IsSecure() result, coverity doesn't like it
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: mayhemer, Assigned: mayhemer)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
702 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
Use 'if (IsSecure()) { *secure = PR_TRUE; return PL_DHASH_STOP; }'
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #393490 -
Flags: review? → review?(timeless)
Attachment #393490 -
Flags: review?(timeless) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 393490 [details] [diff] [review] v1 [Checkin comment 2] http://hg.mozilla.org/mozilla-central/rev/bbf81d249ebd
Attachment #393490 -
Attachment description: v1 → v1 [Checkin comment 2]
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•6 years ago
|
Blocks: coverity-analysis
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•