Closed Bug 506063 Opened 15 years ago Closed 15 years ago

Add rect emptiness check to imgContainer::ExtractCurrentFrame()

Categories

(Core :: Graphics: ImageLib, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: rkawaguchi, Assigned: joe)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: 

imgContainer::ExtractCurrentFrame() does not check if the intersection of the current frame rect and the crop rect is empty of not. If the intersection happens to be empty, it causes an assertion error in imgFrame::Init().

Reproducible: Always
Vlad, is NS_ERROR_NOT_AVAILABLE appropriate for this?
Assignee: nobody → joe
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #390284 - Flags: review?(vladimir)
Comment on attachment 390284 [details] [diff] [review]
add error handling

I would call it NS_ERROR_INVALID_ARG or something, but w/e.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/bdbfdabc77f7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: