Closed Bug 506120 Opened 15 years ago Closed 15 years ago

Add a blocklist to the add-on validator

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Product:
addons.mozilla.org Graveyard
Component:
Admin/Editor Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: clouserw, Assigned: rjwalsh)

References

(
URL
)

Details

Attachments

(2 files, 5 obsolete files)

Post-fix screenshot; WFM
277.20 KB, image/png
Details
smaller patch
10.83 KB, patch
Details | Diff | Splinter Review 
The spec says we need a blocklist so we should add one.  Just simple admin crud and an empty table to hold them for now will be fine.
Really basic stuff here - quick and dirty.  Let me know if we need to elaborate on this
Attachment #390347 - Flags: review?(clouserw)

        Attachment #390347 -
        Attachment is obsolete: true

        Attachment #390356 -
        Flags: review?(clouserw)

        Attachment #390347 -
        Flags: review?(clouserw)

    
    

    
  
Comment on attachment 390356 [details] [diff] [review]
CRUD Framework (forgot to include model and view file)

- the primary key has to be `id`
- you need a migration .sql
- your INSERT doesn't work because you need to specify the columns.
- the GUIDs need to be trim()'d before inserting them into the db

        Attachment #390356 -
        Flags: review?(clouserw) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fixes to previous patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #390356 -
        Attachment is obsolete: true

        Attachment #390359 -
        Flags: review?(clouserw)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fixes to previous patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #390359 -
        Attachment is obsolete: true

        Attachment #390364 -
        Flags: review?(clouserw)

        Attachment #390359 -
        Flags: review?(clouserw)

    
    

    
  
Comment on attachment 390364 [details] [diff] [review]
Fixes to previous patch

r+ after:

1) "UNIQUE KEY `guid` (`guid`)," the trailing comma there is a syntax error and won't work

2) 'GuidBlacklist' in the developers_controller needs to be 'BlacklistedGuid'

        Attachment #390364 -
        Flags: review?(clouserw) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for production push (obsolete)
        — 
          — Splinter Review
      

    


  
Patch for the push to production

        Attachment #390364 -
        Attachment is obsolete: true

    
  

        Attachment #390369 -
        Flags: review+

    
    

    
  
Committed in r30310
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
I blocklisted "ohhai@fun.tld" via https://preview.addons.mozilla.org/en-US/admin/guids, and tried to upload a test add-on with that in its <em:id>ohhai@fun.tld</em:id>, and got the following screenshot, which I'll attach.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        smaller patch
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #390369 -
        Attachment is obsolete: true
Product: addons.mozilla.org → addons.mozilla.org Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: