50631 - Leaking of mSuperWin

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Patrick C. Beard]

whats up with the if { } else { } else { } thing?  shouldn't these just be if ()
{ } without the elses?

pav

Comment 1

[Christopher Blizzard (:blizzard)]

No.  If you have a shell and you destroy it it should destroy all of its
children automatically, including the mozarea and its superwin children.  If you
have a mozarea ( like in the embedding case - no shell ) then when you destroy
it all of the children superwin will be destroyed.  If you just have a superwin
then it will be destroyed.

Comment 2

[Stuart Parmenter]

hmm..  we were seeing a leak of an mSuperWin with the boehm (sp?) collector. 
i'll give you some more data later today

Comment 3

[Christopher Blizzard (:blizzard)]

Related?

http://bugzilla.mozilla.org/show_bug.cgi?id=49540

Comment 4

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 5

[Vedran Miletic]

retargeting

Comment 6

[Jesse Ruderman]

gtk/nsWindow.cpp is gone and gtk2/nsWindow.cpp has nothing called mSuperWin or DestroyNative.  WFM?