50698 - parameter for sendmail deferred mode

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Chris Yeh]

i get tired of having to move processmail out of the way everytime i want to 
check in a change. there should be a parameter for the sendmail deferred mode so 
that it can be easily toggled on or off without having to touch and modify local 
copies of processmail.

Comment 1

[Chris Yeh]

checked in enhancement, there is now a sendmailnow parameter which toggles 
whether we send in deferred mode or not. default is OFF (send in deferred mode)

Comment 2

[Dave Miller [:justdave]]

This patch doesn't work in perl 5.6.  It now queues everything, regardless of 
the param.  For some reason having the 'my' in front of the $sendmailparam 
inside the if() block makes it fail to assign, since you already declared it as 
a 'my' var two lines above.

I just checked in a patch to it.  Removing the 'my' from in front of the 
variables inside the if() blocks fixed it.

Comment 3

[Dave Miller [:justdave]]

*** Bug 50425 has been marked as a duplicate of this bug. ***

Comment 4

[Chris Yeh]

The problem has to do with Perl scoping...the my keyword in the if statement 
effectively makes it a seperate instance of that variable, so it never gets set 
to null since it gets the original value back when it leaves the if statement.

I tested this as best as I could, that's what I get for testing a single bug on 
a fast unloaded machine. (It looked like an immediate send, honestly it did!)

Thanks for the catch and the fix.

Comment 5

[Dave Miller [:justdave]]

In search of accurate queries....  (sorry for the spam)

Comment 6

[Matthew Tuck [:CodeMachine]]

Verified, see also bug #50159.

Comment 7

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product