507142 - need more detailed requirement/error text for bookmarks page

Status: RESOLVED FIXED

(Websites Graveyard :: byob.mozilla.com, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: screenshot

currently it seems we have as requirement for the Website section of the bookmarks page a http://www.whateversite.com, because just www.whateversite.com is marked as error (see screenshot).

Maybe we should also allow www.url.com or we give a more detailed error or requirement text for the Website section, since the error is not so obvious.

Comment 1

[Neil Lee [:neilio]]

I think we shouldn't do error checking here, or if we do, just the most basic -- there may be a lot of things someone might want to add as a bookmark - I could even foresee someone wanting to ship a bookmarklet with their browser, for example -- so maybe this area could be set up more as a "this gun is loaded, don't shoot yourself"?

Comment 2

[Kev Needham [:kev]]

I'd like to ensure that anything we add is an http URI. I _don't_ want people to ship bookmarklets (assuming you mean js), as I believe they run as trusted in the browser so could be an attack vector. So long as it's a full http:// URI, I don't think anything else is needed as we'll be reviewing the bookmarks in place.

The better help text is coming shortly, just finishing the doc up.

Comment 3

[Les Orchard [:lorchard]]

Added error messages for bookmarks in r48539

Might be too much info when there are lots of problems, but not sure how better to handle that.  Leaving this bug open pending any changes to the error message text I threw in there.

Comment 4

[Les Orchard [:lorchard]]

Closing this bug - feel free to reopen or file a new one with changes to error text.