507211 - Fresh clone of tracemonkey repo has an integrity error

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Jason Orendorff [:jorendorff]]

Gary noticed this. It seems pretty serious, although things are working for the time being.

~/dev$ hg clone http://hg.mozilla.org/tracemonkey/ zomg-tracemonkeys
  requesting all changes
  adding changesets
  adding manifests
  adding file changes
  added 30801 changesets with 149253 changes to 48289 files
~/dev$ cd zomg-tracemonkeys/
~/dev/zomg-tracemonkeys (+no patches applied)$ hg verify
  checking changesets
  checking manifests
  crosschecking files in changesets and manifests
  checking files
    modules/plugin/sdk/samples/testevents/README.txt@18759: c9e849ac4765 not in manifests
  48289 files, 30801 changesets, 149253 total revisions
  1 integrity errors encountered!
  (first damaged changeset appears to be 18759)

Comment 1

[Aravind Gottipati [:aravind]]

Thanks for the report.  Copying djc, the mercurial guru for his input.

Comment 2

[Dirkjan Ochtman (:djc)]

Looks like this is pretty harmless. modules/plugin/sdk/samples/testevents/README.txt was deleted in f1f91428a758, but it seems to have revision data for that revision anyway, which is throwing it off (that is, there's a revision in the filelog with linkrev 18759 <=> f1f91428a758, but modules/plugin/sdk/samples/testevents/README.txt is not in the manifest for f1f914).

There are no manifests references from the changelog that refer to the second revision for modules/plugin/sdk/samples/testevents/README.txt, so that revision should probably be stripped from the filelog. I'll come up with a repaired filelog.

Comment 3

[Jason Orendorff [:jorendorff]]

Thanks very much, Dirkjan.

Comment 4

[matthew zeier [:mrz]]

Any other IT action you need here?

Comment 5

[Dirkjan Ochtman (:djc)]

Yes; sorry, I've been working on other things.

Comment 6

[Dirkjan Ochtman (:djc)]

Okay, here's how to fix this.

- Download my fixed version of the filelog from http://dirkjan.ochtman.nl/files/_r_e_a_d_m_e.txt.i

- Make sure no revisions since 74d13b011682 (the latest one I have) have added a file at modules/plugin/sdk/samples/testevents/README.txt (use hg log <path> to verify that f1f91428a758 is the last revision).

- Make sure no one can access the repo.

- Replace the file at .hg/store/data/modules/plugin/sdk/samples/testevents/_r_e_a_d_m_e.txt.i by the file you downloaded from my site.

- Run hg verify to make sure everything is alright (a local -U clone wouldn't take too much time and makes for a nice backup strategy).

- If the verify checks out, you're all done, re-enable repo access now.

Comment 7

[Aravind Gottipati [:aravind]]

Thanks djc for the fix.  Repo should be clean now.