Closed
Bug 507214
Opened 15 years ago
Closed 15 years ago
Add a src parameter to all install/download buttons
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
5.2
People
(Reporter: fligtar, Assigned: rdoherty)
References
Details
Attachments
(1 file)
6.41 KB,
patch
|
davedash
:
review+
|
Details | Diff | Splinter Review |
We should have a src= parameter for every add-on install/download button. I am aware of the following locations that are missing them currently: * Category pages (src=category) (include general add-on type pages here, like Search Tools, Themes, etc.) * Search pages (src=search) * Collection pages (src=collection) (we currently have collection_id which says the specific collection, but we need a src parameter) * Recommended page (src=recommended) * Tabs in homepage browse section (src=homepagebrowse)
Reporter | ||
Comment 1•15 years ago
|
||
I thought we added a src to the API download link, but looks like it was only the learnmore link? https://preview.addons.mozilla.org/en-US/firefox/api/1.1/search/web%20developer/all/10/Darwin/3.0.6 So, one more: * API (src=api)
Updated•15 years ago
|
Target Milestone: 5.0.9 → ---
Reporter | ||
Updated•15 years ago
|
Priority: -- → P1
Target Milestone: --- → 5.2
Reporter | ||
Updated•15 years ago
|
Assignee: nobody → rdoherty
Assignee | ||
Comment 3•15 years ago
|
||
Added src parameters where specified.
Attachment #404716 -
Flags: review?(ddahl)
Assignee | ||
Updated•15 years ago
|
Attachment #404716 -
Flags: review?(ddahl) → review?(dd)
Updated•15 years ago
|
Attachment #404716 -
Flags: review?(dd) → review+
Assignee | ||
Comment 4•15 years ago
|
||
r52970
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Keywords: push-needed
Comment 5•15 years ago
|
||
Verified on preview for Collections, HomePage browse category pages and Search pages.
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Keywords: push-needed
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•