507349 - filter dialog unusable when opened in smart folders mode

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Tools | Message Filters is unusable if you open it in smart folders mode.

Error: uncaught exception: unable to find folder to select!

Error: gCurrentFilterList is undefined
Source File: chrome://messenger/content/FilterListDialog.js
Line: 294

Comment 1

[Kent James (:rkent)]

Attachment: Set canHaveFilters false for smart folders server

Thought I'd give a little effort to a blocker.

Comment 2

[David :Bienvenu]

thx a lot for looking at this, Kent. Why not change the nsIMsgIncomingServer canHaveFilters attribute to be read write?

Comment 3

[Kent James (:rkent)]

That would work as well - and I assume that is what you prefer from your question. I don't have a strong opinion, I was just trying to follow as much as possible the existing design, which seemed to be that subclasses were responsible to implement that for themself.

Comment 4

[David :Bienvenu]

yes, I prefer that - subclasses are one thing, but having a separate interface that essentially overrides the value could be a little confusing.

Comment 5

[Kent James (:rkent)]

Attachment: remove readonly from canHaveFilters in nsIMsgIncomingServer

Here's the version doing the change at the parent class instead.

Comment 6

[David :Bienvenu]

Comment on attachment 394337 [details] [diff] [review]
remove readonly from canHaveFilters in nsIMsgIncomingServer

this looks good, but can you add an NS_ENSURE_ARG_POINTER to GetCanHaveFilters for correctness (and Venkman's) sake?

Comment 7

[Kent James (:rkent)]

Attachment: Fixed nits [Checkin: Comment 8]

Patch to checkin.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 394344 [details] [diff] [review]
Fixed nits
[Checkin: Comment 8]


http://hg.mozilla.org/comm-central/rev/6ba55ef79e06