50741 - deletion of bullet list content does not delete all bullet items

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[rubydoo123]

1.open composer
2.insert list, make sure you have at least 3 list items, add text to each list 
item
3.highlight all of the text in the list, press any key

what happens: one of the additional bullet items remains, instead of just the 
first item

expected: only the first list item should remain

Comment 1

[rubydoo123]

setting to m19

Comment 2

[Joe Francis]

accepting this bug as if it were my own son.  which it is.

Comment 3

[Joe Francis]

sometimes this happens, sometimes it doesnt.  i believe what's happening is this: 
if the last list item has a trailing br, you wont see it (the br ends a line but 
does not cause a new line: you need more text after it or another br for that to 
happen).  When you select sometimes you end up selecting that last be and 
sometimes you don't.  When you dont, it ends up in a list item all by itself, 
like it should.  The real problem is that there is no way for the user to see the 
br, or know if it's selected.

cc'ing mike.  Mike, i think if you drag select past a text node, going below and 
to the right of it, you sometimes don't get the br following it selected.  Maybe 
we should always select it in that case.

Comment 4

[Joe Francis]

mike and i stepped through this.  It's true that depending on how you do the 
selection, you get a subtly different selection range.  But the deletion code 
should bahve the same way for the two different possibilities, so this is 
definitely my bug.  I'll try to fix this during the b3 "quiet period", though I 
doubt anyone will let me check it in.

Comment 5

[rubydoo123]

setting to future, adding helpwanted

Comment 6

[rubydoo123]

*** Bug 71875 has been marked as a duplicate of this bug. ***

Comment 7

[rubydoo123]

moving to moz0.9.2 per triage meeting

Comment 8

[shrirang khanzode]

Attachment: sweet testcase

Comment 9

[shrirang khanzode]

open the testcase above in composer, highlight all of the text with mouse and 
press any character key on keyboard. Observe that the first item stays but 
another empty list item stays there too.

Comment 10

[Joe Francis]

fixed by my changes in 091

Comment 11

[shrirang khanzode]

yeah, veirifed fixed on 0523. Testcase works fine now.