507963 - Intermittent failure of browser_privatebrowsing_findbar.js

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249259743.1249266076.16877.gz#err0

This must be intermittent, since the previous test run was green with the same changeset.

Comment 1

[Marco Bonardo [:mak]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249292316.1249294121.25418.gz

Comment 2

[Marco Bonardo [:mak]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249293210.1249295207.4721.gz

Comment 3

[Marco Bonardo [:mak]]

this is happening quite frequently
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249299923.1249301769.15334.gz

Comment 4

[Markus Stange [:mstange]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249343354.1249344868.24553.gz

Comment 5

[Johnathan Nightingale [:johnath]]

Copying Ehsan since he wrote the test, and mconnor since he reviewed it - this is a frequent intermittent orange - is there a real problem here, or just a faulty test?

Comment 6

[Daniel Holbert [:dholbert]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249493775.1249500278.21100.gz

Comment 7

[Markus Stange [:mstange]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249503155.1249505112.9476.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249508026.1249509635.27191.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249509080.1249510678.6170.gz

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.0

SynthesizeKey on Linux has focus issues, see bug 495751.
if you see above the test failed only on Linux, and i can see why since it uses a bunch of synthesizeKey. Actually putting a window.focus() and focusing the textbox COULD be enough, but no reasons really, value is just working the same way.

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 392827 [details] [diff] [review]
patch v1.0

The window probably doesn't have focus, and making sure it does (by explicitly focusing it) should make sythesizeKey work.

Comment 10

[Marco Bonardo [:mak]]

Yes, but still focus on Linux is still bogus, and i really think we should not make browser-chrome tests that depends on focus if we don't really need.

Comment 11

[Marco Bonardo [:mak]]

Attachment: patch v2.0

i cannot guarantee this will work as reliably as patch v1.0, i still think that is the right way to go. But if we want to try focus fix first, here it is.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249516256.1249521503.27589.gz
Linux mozilla-central unit test on 2009/08/05 16:50:56

Comment 13

[Shawn Wilsher :sdwilsh]

Comment on attachment 392831 [details] [diff] [review]
patch v2.0

Yes, I'd prefer to try this first as it's more like what the user would actually do.

r=sdwilsh

Comment 14

[(no longer active)]

Actually, reading bug 495751 and bug 497839, it seems that window.focus might sometimes work asynchronously.  Given that, and the fact that the synthesizeKey calls in this test are merely an attempt at imitating the real user as much as possible and don't really have any special value to the test at hand, I would prefer the first approach in order to avoid any possible similar problems in the future.

Testing that focusing a text box and synthesizing keyboard events to it has the same effect as setting its value property should be a test in the XUL widget code, and it's not too important to worry about it here.

Comment 15

[Marco Bonardo [:mak]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1249543607.1249545293.23267.gz

Comment 16

[(no longer active)]

Comment on attachment 392831 [details] [diff] [review]
patch v2.0

Given bug 495751, this is bound to cause further intermittent oranges.

Comment 17

[(no longer active)]

Comment on attachment 392827 [details] [diff] [review]
patch v1.0

r=ehsan

Marco, please proceed to land this when the tree reopens.

Comment 18

[Marco Bonardo [:mak]]

thank you.
http://hg.mozilla.org/mozilla-central/rev/a1de621405d2

Comment 19

[(no longer active)]

Thanks for picking this up!  This needs to land on 1.9.1 as well.

Comment 20

[Marco Bonardo [:mak]]

oh. i thought test was not active there. i don't see failures on 1.9.1 above

Comment 21

[(no longer active)]

I suspect that the test failures happen by something done by other tests.  I am suspecting the cert exceptions test which opens up dialogs, and hence changes the focus.  I'd rather land this now and avoid future oranges than wait till we see oranges on 1.9.1 and then land it there.

Comment 22

[Marco Bonardo [:mak]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249598578.1249606404.18266.gz
Linux mozilla-central unit test on 2009/08/06 15:42:58

this failure is not relevat, it is on the push that created the 3.6a1 branch, and it's based on a changeset that is older than the fix for this test.

Comment 23

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b12d1de93e53

Comment 24

[Legacy TBPL/Treeherder Robot]

paul%oshannessy.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287089459.1287091577.12715.gz
Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2010/10/14 13:50:59

s: talos-r3-fed-042
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js | No items in the undo list of the findbar control - Got 1, expected 0

Comment 25

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #24)
> paul%oshannessy.com
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287089459.1287091577.12715.gz
> Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2010/10/14
> 13:50:59
> 
> s: talos-r3-fed-042
> TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js
> | No items in the undo list of the findbar control - Got 1, expected 0

Ignore this!