507988 - gfx.downloadable_fonts.enabled should be live apply

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[timeless]

prefs should really be live apply.... i'm not quite sure how to flush font face rules from existing pages, but we can at least let users influence new pages.

Comment 1

[timeless]

Attachment: proposal

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 392224 [details] [diff] [review]
proposal

A couple drive-by comments....

>+#define GFX_DOWNLOADABLE_FONTS_ENABLED "gfx.downloadable_fonts.enabled"

How about making this a static const char* as well, like the CMS prefs?

>+    } else if (pref.EqualsLiteral(GFX_DOWNLOADABLE_FONTS_ENABLED)) {
>+        if (gPlatform)
>+            gPlatform->DownloadableFontsEnabled();

I don't see how just calling DownloadableFontsEnabled() here will cause the change to be noticed. Once sDownloadableFontsInitialized has been set to TRUE, that function becomes a no-op. Were you intending to reset that flag to FALSE here? (And then there'd be no need to actually call the function.)

Comment 3

[John Daggett (:jtd)]

Comment on attachment 392224 [details] [diff] [review]
proposal

The value of 'sDownloadableFontsInitialized' needs to be reset in the ::Observe method I think.

The patch on bug 504698 should resolve the lack of live apply for this pref.

Comment 4

[Chris Lord [:cwiiis]]

This works as expected in current Aurora.