508398 - Join link available to logged-in users

Status: VERIFIED FIXED

(Websites :: creative.mozilla.org, defect)

Description

[krupa raj[:krupa]]

Attachment: Join link

steps to reproduce:
1.Log in to your MCC account
2.In the "Thanks for Visiting" section,notice the messaging and the availability of Join link

expected behavior:
-Join link is not available for logged in users
-"Thanks for visiting" section is not suitable for logged-in users.

Comment 1

[krupa raj[:krupa]]

Attachment: join link in About page

steps to reproduce:
1.Login
2.go to http://mcc.stage.mozilla.com/about

Notice the join us link

Comment 2

[raymond [:retornam] (inactive)]

http://screencast.com/t/1iTLFH1vj5v

After clicking the link on the about page it shows this error message which is fine in my opinion

Comment 3

[krupa raj[:krupa]]

Raymond,

Having an error message is good in such a situation.But providing the link to logged in users and compensating that error with an error message is not ideal.We should retain the error message for edge-case scenarios and remove the link for logged-in users.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Removed Join link from homepage, slide 1 of the slideshow:

Sending        application/controllers/home.php
Sending        application/views/home/home_index.php
Sending        modules/auth/controllers/auth.php
Sending        modules/auth/i18n/en_US/auth.php
Transmitting file data ....
Committed revision 48819.

==

Removed Join link from the About us page.  Verified /register page redirects user and throws appropriate error if they are logged in.

Sending        application/controllers/about.php
Sending        application/views/about/about_faq.php
Sending        application/views/about/about_index.php
Transmitting file data ...
Committed revision 48820.

Comment 5

[Tom Ellins [:TMZ]]

Join link removal looks good but per comment #1 "Thanks for visiting" section is not suitable for logged-in users." Do we want the whole "thanks for visiting" slide gone or just the link?

Comment 6

[krupa raj[:krupa]]

reopening as per comment #5

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Per Tara:
I would say lets keep the slide, and the text... but change the title so that it's not a link when you're logged in.  
Slater? Jeff?

Per Jeff:
Yes, having the "join" link taken away when logged in makes sense to me, if that is possible. I think it's still ok to have a thanks for visiting tab there, even for users that are logged in

==

Made the title not be a link if the user is loggedin.

Sending        application/views/home/home_index.php
Transmitting file data .
Committed revision 48901.

Comment 8

[krupa raj[:krupa]]

verified