508469 - Create Contributions dashboard

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Nick Nguyen [:osunick]]

See attached for mini spec and mockup.  This should live on the statistics dashboard section and the Contributions dropdown appears for all developers.  If no contributions have been made, the section just says "You haven't received any Contributions yet."

Comment 1

[Nick Nguyen [:osunick]]

Attachment: Mockup and mini spec

Comment 2

[Wil Clouser [:clouserw]]

->mccammos.  This is dependent on us getting stats which is 2 metrics bugs I haven't filed yet.  So...code is good, but be a bit flexible with the starting data for now.

Comment 3

[Nick Nguyen [:osunick]]

just talked to justin fitzhugh- this will get attention this monday.  also adding a mock for the admin version of this dashboard

Comment 4

[Nick Nguyen [:osunick]]

Attachment: admin dashboard

this is viewed from the admin cp (just another box in the left nav)

Comment 5

[Nick Nguyen [:osunick]]

scott- fyi, only rows with null uuid's are completed transactions.  uuid's that aren't null are for all intents and purposes clicks where the user decided not to pay.

Comment 6

[Scott McCammon [:mccammos]]

Attachment: Basic Dev Dashboard

Here is my first stab as the clock runs out. Adds to the dev-side dashboard a contribution timeplot and summary. It also uses the existing data table code already in place, but this lacks any custom formatting.

Usable but not complete (or perfect).

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 395787 [details] [diff] [review]
Basic Dev Dashboard

With or without contributions I get an alert that says "Caught exception: undefined. Details: TypeError: event.getStart() is null" when I try to view the contributions graph.

Other than that this appears to work fine.

Comment 8

[Scott McCammon [:mccammos]]

(In reply to comment #7)
> With or without contributions I get an alert that says "Caught exception:
> undefined. Details: TypeError: event.getStart() is null" when I try to view the
> contributions graph.

It seems that IE has a few problems with the dashboard javascript - even on production. I'll look into it.

Comment 9

[Scott McCammon [:mccammos]]

Filed bug 511927 for plot errors in IE since this affects more than this bug.

Comment 10

[Wil Clouser [:clouserw]]

I wasn't using IE but scott says he can't reproduce this.  Let's land on preview and see what happens there.  I might just have broken data.

Comment 11

[Scott McCammon [:mccammos]]

Committed in r49737.

I blame timeplot for not gracefully handling any issues with the many data requests it makes. We shall see.

Comment 12

[Wil Clouser [:clouserw]]

Reproduced the error on preview.  Scott is fixing

Comment 13

[Scott McCammon [:mccammos]]

Attachment: Ignore NULL amounts

The timeplot alert issue was reproducible when a contribution had a null amount. Any successful and valid contribution will have a positive amount so we can safely exclude records with null or negative amounts.

Comment 14

[Wil Clouser [:clouserw]]

Comment on attachment 395949 [details] [diff] [review]
Ignore NULL amounts

I'll r+ but do you know why we have null amounts in the db in the first place?  Is that just left over data from somewhere?

Comment 15

[Scott McCammon [:mccammos]]

(In reply to comment #14)
> (From update of attachment 395949 [details] [diff] [review])
> I'll r+ but do you know why we have null amounts in the db in the first place? 
> Is that just left over data from somewhere?

Null is the default value when the user doesn't choose the suggested amount. Only Paypal knows the final amount, so we depend on metrics to fill things in later.

Comment 16

[Scott McCammon [:mccammos]]

A point that I should have clarified earlier: The current implementation
assumes contribution stats are viewing only by owners and admins - even for
add-ons with public stats.

Wil thought we might want a note to explain who can/can't see this data. A
footnote below the contribution summary table would probably work.

Was this assumption correct? If not it is trivial to make public for public
stat add-ons.

Comment 17

[Scott McCammon [:mccammos]]

Ignore NULL patch added in r49752.

Comment 18

[Wil Clouser [:clouserw]]

I think it's a good assumption (I was actually thinking we'd need to file a bug to make it an option, but this works).  I think /statistics/settings/$id would be the page to put a note on.  Just something simple like "contributions are only ever shown to authors and site administrators"  or something.

Comment 19

[Scott McCammon [:mccammos]]

Resolving as fixed for 5.0.9, and filed bug 511996 for implementation of remaining features.

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- this is in (I've been testing it and filing/verifying bugs accordingly.)