508694 - Not use thread summary view for newsgroups which aren't offline

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

This seems to have be a new feature that arrived with TB3 beta 3.

This really interferes with reading newsgroups, because when I press "n" to go to the next unread message, first have to deal with a useless summary view (see screenshot). I can skip past it with another "n", but it really just shouldn't be there. It provides no useful information, and even if it did it's not what I'm expecting to see.

Comment 1

[Joe Sabash [:JoeS1]]

Possible dup of bug 498415
Marked fix on 2009-07-26

Using "n" opens the next thread correctly for me using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090804 Lightning/1.0pre Shredder/3.0b4pre ID:20090804034606

Comment 2

[Joe Sabash [:JoeS1]]

Oh, and I disagree that the feature is not useful to summarize posts, without actually expanding the thread.
That only should happen when you click on a collapsed thread, however.

Comment 3

[David Ascher (:davida)]

Note: for offline news folders, bug 478167 would help make the summaries useful.

Comment 4

[David Ascher (:davida)]

First pass would be to not do summaries for news folders at all.

Comment 5

[Mark Banner (:standard8)]

Attachment: Proposed fix

This does David's suggestion and disables summarizing the selection for newsgroups completely. When we fix bug 478167 we can re-enable it for offline newsgroups.

Note that I've created a summarizeSelectionInFolder attribute to make it clearer what we're checking and save copy/pasting the pref everywhere.

I have also fixed a bug whereby if mail.operate_on_msgs_in_collapsed_threads was false then we wouldn't display the first message in a thread with the thread collapsed.

The only thing that this changes that may or may not be desirable is that actions on collapsed threads in newsgroups will no longer apply to the whole thread. As we don't have the summary page that may be acceptable though. Hence requesting ui-review.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 396292 [details] [diff] [review]
Proposed fix

sounds good

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 396292 [details] [diff] [review]
Proposed fix

Good improvements all around, especially the bug fix :)

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/da09a490e33b