Closed Bug 508729 Opened 15 years ago Closed 15 years ago

Cache Bugzilla::Status::BUG_STATE_OPEN

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: mkanat, Assigned: mkanat)

Details

(Whiteboard: [es-gnome])

Attachments

(1 file)

I have some code that I'm running in an extension where most of the time is taken up by calling BUG_STATE_OPEN. Its return value should be cached.
Attached patch v1Splinter Review
Let me know if you think this is safe enough to backport to 3.4.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #392868 - Flags: review?(LpSolit)
Comment on attachment 392868 [details] [diff] [review]
v1

Looks good to me. Should be a nice perf improvement. r=LpSolit
Attachment #392868 - Flags: review?(LpSolit) → review+
And yes, I think it's safe for 3.4.
Flags: approval3.4+
Flags: approval+
Target Milestone: Bugzilla 3.6 → Bugzilla 3.4
Oh, and as I said on IRC, don't forget to clear the cache in remove_from_db() too.
I did the checkin fix.

Checking in Bugzilla/Status.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Status.pm,v  <--  Status.pm
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [es-gnome]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: