508774 - nsGlobalModalWindow traverses mArguments twice

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

nsGlobalModalWindow traverses mArguments, which is already traversed in its base class (nsGlobalWindow). This means the cycle collector might be collecting live objects. It doesn't traverse its own member mReturnValue but does unlink it.

I found this from code inspection and I don't have a testcase, so no idea how bad it is. We should be nulling out pointers when unlinking so I don't think we'll end up with stale pointers.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Peter: do you think this should block the alpha? That's what P1 blockers mean at this time ...

Comment 2

[Peter Van der Beken [:peterv]]

Nope.

Comment 3

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/a4c48ea78e74

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1 (1.9.1 branch version)

This fixes the leaks from bug 504862. Safe patch, has been on trunk since beginning of August.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 415604 [details] [diff] [review]
v1 (1.9.1 branch version)

Approved for 1.9.1.7 and 1.9.0.17, a=dveditz for release-drivers

Please land this before bug 504862

Comment 6

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e72d4faef77f