Closed Bug 50889 Opened 24 years ago Closed 24 years ago

UMR: nsLocalStringService::GetBundle()

Categories

(MailNews Core :: Internationalization, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bruce, Assigned: sspitzer)

Details

Attachments

(1 file)

67 nsLocalStringService::GetBundle(nsIStringBundle **aResult)
 68 {
 69   NS_ENSURE_ARG_POINTER(aResult);
 70   nsresult rv;
 71   if (!mLocalStringBundle)
 72     rv = InitializeStringBundle();
 73   NS_ENSURE_SUCCESS(rv, rv);

If mLocalStringBundle, rv -> uninitialized.  Please initialize on line 70?

 74 
 75   *aResult = mLocalStringBundle;
 76   NS_IF_ADDREF(*aResult);
 77   return NS_OK;
 78 }
Reassign to alecf.
Assignee: nhotta → alecf
Attached patch proposed fixSplinter Review
easy fix. cc sspitzer and mscott for r=/sr=
Status: NEW → ASSIGNED
sr=mscott
seth will take care of this with another patch he has
Assignee: alecf → sspitzer
Status: ASSIGNED → NEW
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Belatedly I am going to verify the fix on this bug.
The fix was checked in connection with Bug 59617, which
makes it possible to initialize uninitialized variable. See:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsLocalStringBundle.cpp&root=/cvsroot&sub
dir=mozilla/mailnews/local/src&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8

Marking it verified as fixed.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: