509342 - NSS packaging changes for MOZILLA_1_8_BRANCH

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Project changes

Once we get sqlite building properly in bug 504523, these are the changes we'll need for the project.  Very lightly tested; connecting to https:// sites works, and I can view certificates in the Certificates window.

Note: I looked at the trunk changes when we upgraded NSS there, and we were only linking libnssutil3.dylib (and libsqlite3.dylib), so those were the only two I added.  

However, the situation on the trunk is pretty inconsistent, so I'm not sure if we should be linking more (I wonder if maybe linking more would get rid of some of the bizarre NSS bugs we have):

* Static doesn't link against libnssckbi.dylib or libnssdbm3.dylib

* Shared doesn't link against libnss3, libnssckbi, libnssdbm3, libsmime3, libsoftoken3, or libssl3 (basically, it links only freebl3, nssutil3, sqlite3!)

I'm also not sure the ../dist/bin search path; it's not there on trunk for StaticApp's Development or Deployment, but I doubt it hurts.

I plan on landing this as soon as we can get the sqlite Makefile fixed, but requesting (possible post-facto) review anyway, particularly for the above points.

Comment 1

[Stuart Morgan]

Comment on attachment 393463 [details] [diff] [review]
Project changes

I have no idea what we should be linking, so I don't have insight on that part of it :(

../dist/bin is part of the search paths in our xcconfig; Xcode is adding a redundant entry that should be stripped back out (it won't hurt, but there's no good reason to have it there).

sr=smorgan otherwise; green=good.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Ah, I wondered where the source of the "$(LIBRARY_SEARCH_PATHS)" was; I removed the spurious Xcode-trying-to-be-helpful additions.

I'm actually going to land this now, since it won't make us any more broken than we are right now, and then we'll go green immediately after my patch on bug 504523 lands.

When I get a chance, I'll try to remember to try linking the other libs (or reading a Firefox build log) to see if I can see if they fix any of the other bizarre bugs.

Comment 3

[Eiichi]

Build Failure 
Mac OS X Version 10.4.11 (Build 8S2167)
XCode Tools Version: 2.5
-----------
Mon Aug 10 16:32:13 JST 2009
/usr/bin/make -j1: *** No rule to make target /Camino/mozilla/obj-i686-apple-darwin8.11.1/dist/lib/libsoftokn3.chk.  Stop.
make[4]: *** [/Camino/mozilla/obj-i686-apple-darwin8.11.1/dist/lib/libsoftokn3.chk] Error 1
make[3]: *** [libs] Error 2
make[2]: *** [tier_50] Error 2
make[1]: *** [alldep] Error 2
make: *** [alldep] Error 2
-----------

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The extra patch in bug 504523 hasn't landed yet; that should happen later today (you may still need to clobber your tree to get NSS to build correctly).

Also note the actual failure is some 20+ lines up, where ld complains about missing symbols ;)

Comment 5

[Eiichi]

(In reply to comment #4)
> The extra patch in bug 504523 hasn't landed yet; that should happen later today
> (you may still need to clobber your tree to get NSS to build correctly).

Thanks, Smokey.
Now I can succeed building.